Remove abstract classes #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1925,7 +1925,7 @@ module themeOverrides = | |||
| static member inline centered(styles: IStyleAttribute list) : IThemeProp = unbox ("overrides.MuiTabs.centered", createObj !!styles) | |||
| /// Styles applied to the tablist element. | |||
| static member inline scroller(styles: IStyleAttribute list) : IThemeProp = unbox ("overrides.MuiTabs.scroller", createObj !!styles) | |||
| /// Styles applied to the tablist element if `!variant="scrollable"`. | |||
| /// Styles applied to the tablist element if `!variant="scrollable"`. | |||
There was a problem hiding this comment.
The IDE was complaining there was an invisible character here invalidating the XML doc.
There was a problem hiding this comment.
I see. This will be reverted the next time the generator runs, though. I'll see about fixing it there.
|
Thanks, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this fixes #59. I've tested it by building the docs and they seem to run correctly.
Fable 3 mangles members of abstract classes by default. This is kind of a breaking change and we may revert it at some point, but I think using interfaces for the bindings is cleaner here so if you don't mind @cmeeren we can merge this and publish a new version to make things compatible with Fable 3 (it will still work fine with Fable 2). Reasons why interfaces are preferred:
AbstractClassandEraseand all members are abstracts, there are no a couple ofmember inlineoutliers.Emitcan be used directly on interface members and it also inlines the code, so it has the same effect asmember inline.BreakpointsI'm using extensions instead withAutoOpen. This shouldn't break consume code.