Fixed executable path to always point to a node file #401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #355
Currently we rely on node to generate the os dependant executable files pointing to the node cli.js and add the path to one of them as the node_executable field in the configuration given to the extension server. The Go binary then tries to execute with node this path. This causes an error in Windows as it creates both bash and a cmd files which are not supported by node.
WHAT is this pull request doing?
Instead of relying on the node generated files point directly cli.js path in the configuration.
How to test your changes?
yarn create-app
cd app-folder
yarn scaffold extension
yarn dev