Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed executable path to always point to a node file #401

Merged
merged 2 commits into from
Aug 31, 2022

Conversation

alfonso-noriega
Copy link
Contributor

@alfonso-noriega alfonso-noriega commented Aug 31, 2022

WHY are these changes introduced?

Fixes #355

Currently we rely on node to generate the os dependant executable files pointing to the node cli.js and add the path to one of them as the node_executable field in the configuration given to the extension server. The Go binary then tries to execute with node this path. This causes an error in Windows as it creates both bash and a cmd files which are not supported by node.

WHAT is this pull request doing?

Instead of relying on the node generated files point directly cli.js path in the configuration.

How to test your changes?

  • create an app yarn create-app
  • create an extension for the app:
    • cd app-folder
    • yarn scaffold extension
  • dev the app+extension yarn dev

@alfonso-noriega alfonso-noriega linked an issue Aug 31, 2022 that may be closed by this pull request
2 tasks
@alfonso-noriega alfonso-noriega requested a review from a team August 31, 2022 13:05
Copy link
Contributor

@pepicrft pepicrft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a changeset entry with yarn changeset add.

@alfonso-noriega alfonso-noriega marked this pull request as ready for review August 31, 2022 13:26
@alfonso-noriega alfonso-noriega requested a review from a team August 31, 2022 13:26
@alfonso-noriega alfonso-noriega force-pushed the fix/expecting-node-executable-but-genarating-cmd-file branch from d98e0b0 to b777c41 Compare August 31, 2022 13:29
@pepicrft pepicrft merged commit 4e385af into main Aug 31, 2022
@shopify-shipit shopify-shipit bot temporarily deployed to production August 31, 2022 15:01 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Post purchase extensions not working
2 participants