Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed executable path to always point to a node file #401

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Fixed executable path to always point to a node file #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba8f907
Fixed executable path to always point to a node file
alfonso-noriega Aug 31, 2022
b777c41
Added changeset info
alfonso-noriega Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/few-zoos-repair.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/app': minor
---

Fixed bug when running CLI on Windows machine. The node executable path is now pointing directly to a node file instead of relying in the node generated files.
2 changes: 1 addition & 1 deletion packages/app/src/cli/utilities/extensions/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export async function nodeExtensionsCLIPath(): Promise<string> {
cwd,
})) as string
} else {
const executablePath = await path.findUp('node_modules/.bin/shopify-cli-extensions', {
const executablePath = await path.findUp('node_modules/@shopify/shopify-cli-extensions/dist/cli.js', {
type: 'file',
cwd,
allowSymlinks: true,
Expand Down