Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Shopify/hydrogen-cli for development server #1089

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Adds Shopify/hydrogen-cli for development server #1089

merged 2 commits into from
Apr 19, 2022

Conversation

cartogram
Copy link
Contributor

@cartogram cartogram commented Apr 15, 2022 •
edited
Loading

Description

Uses the latest Shopify CLI and Hydrogen CLI dev command to start the Demo store.

Additional context

We could start replacing the other commands as well, but want to start with just dev for now incase there are any dependency issues.

Before submitting the PR, please make sure you do the following:

  • Read the Contributing Guidelines
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
  • Update docs in this repository according to your change
  • Run yarn changeset add if this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning

@caution-tape-bot
Copy link

👋 It looks like you're updating JavaScript packages that are known
to cause problems when duplicated.

You can deduplicate them with the yarn-deduplicate utility:

npx yarn-deduplicate --packages graphql react react-dom webpack
npx yarn-deduplicate --scopes @shopify @apollo

If running these commands doesn't produce a change in your yarn.lock file,
you didn't have duplications in these packages and can carry on.

A duplicate React version may cause an invalid hook call warning.

React context providers usually use module-scoped globals as their
default context values. Multiple versions of such packages will yield
multiple global instances, resulting in oblique runtime errors.

@cartogram cartogram requested review from a team and pepicrft April 15, 2022 19:32
@cartogram
Copy link
Contributor Author

Strange timing! 👻 This issue is also related Shopify/hydrogen#1088

jplhomer
jplhomer approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@jplhomer jplhomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell yes! Works for me https://stackblitz.com/edit/shopify-hydrogen-jpzql4?title=Hydrogen

@jplhomer jplhomer merged commit 3c18966 into v1.x-2022-07 Apr 19, 2022
@jplhomer jplhomer deleted the @cartogram/cli-commmands branch April 19, 2022 14:30
@github-actions github-actions bot mentioned this pull request Apr 19, 2022
Merged
blittle added a commit that referenced this pull request Apr 19, 2022
@blittle
Merge branch 'v1.x-2022-07' into jl-persisted-state
b7113d8 
* v1.x-2022-07: (37 commits)
  Adds Shopify/hydrogen-cli for development server (#1089)
  Make `useUrl()` reactive for subscribing to navigation events (#1082)
  fix e2e tests
  streaming and suspense draft (#1033)
  [Hydrogen docs]: Restructure and simplify IA (#1079)
  Use new storefront API headers in queryShop API helper (#1075)
  Remove the dep of hydrogen-ui for now until we get it publishing (#1076)
  [ci] release v1.x-2022-07 (#1048)
  Introduce a synchronous-looking version of fetch for server and client (#983)
  improve the current type of ShopifyContextValue to be based on ShopifyConfig (#1072)
  Foundational work to split hydrogen-ui to its own package (#1060)
  Allow returning new requests from API routes (#1057)
  [Hydrogen docs]: Analytics (#962)
  Analytics (#890)
  Allow line breaks inside script tags (#1061)
  Fix encoding of CSS Modules to solve hydration errors (#1062)
  [Hydrogen docs]: Update guidance on troubleshooting third-party dependencies (#1055)
  Update Vite RSC Plugin (#1054)
  Fix link prefetch (#1059)
  Initial devTools component (#998)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplhomer jplhomer jplhomer approved these changes

@pepicrft pepicrft Awaiting requested review from pepicrft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cartogram @jplhomer