Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hydrogen docs]: Analytics #962

Merged
merged 22 commits into from
Apr 11, 2022
Merged

[Hydrogen docs]: Analytics #962

merged 22 commits into from
Apr 11, 2022

Conversation

mcvinci
Copy link
Contributor

@mcvinci mcvinci commented Mar 21, 2022 •
edited
Loading

This PR:

Tophatted

screencapture-shopify-dev-myshopify-io-custom-storefronts-hydrogen-framework-analytics-2022-04-11-12_13_02

@mcvinci mcvinci self-assigned this Mar 21, 2022
@mcvinci mcvinci requested a review from wizardlyhel March 21, 2022 00:25
@mcvinci
Copy link
Contributor Author

mcvinci commented Mar 21, 2022

@wizardlyhel These are the source docs that correspond with https://github.com/Shopify/shopify-dev/pull/17920 and the work you've been doing in Shopify/hydrogen#890. Open to any feedback!

@mcvinci mcvinci force-pushed the hydrogen-analytics-docs branch from d424819 to 17a470f Compare March 21, 2022 21:37
@wizardlyhel wizardlyhel mentioned this pull request Mar 31, 2022
Merged
4 tasks
mcvinci
mcvinci commented Mar 31, 2022
View reviewed changes
packages/hydrogen/src/framework/docs/analytics.md Outdated Show resolved Hide resolved
packages/hydrogen/src/framework/docs/analytics.md Outdated Show resolved Hide resolved
packages/hydrogen/src/framework/docs/analytics.md Outdated Show resolved Hide resolved
packages/hydrogen/src/framework/docs/analytics.md Outdated Show resolved Hide resolved
packages/hydrogen/src/framework/docs/analytics.md Outdated Show resolved Hide resolved
packages/hydrogen/src/framework/docs/analytics.md Outdated Show resolved Hide resolved
packages/hydrogen/src/framework/docs/analytics.md Outdated Show resolved Hide resolved
packages/hydrogen/src/framework/docs/analytics.md Outdated Show resolved Hide resolved
packages/hydrogen/src/framework/docs/analytics.md Outdated Show resolved Hide resolved
packages/hydrogen/src/framework/docs/analytics.md Outdated Show resolved Hide resolved
@mcvinci mcvinci force-pushed the hydrogen-analytics-docs branch from b096c9c to 3303674 Compare March 31, 2022 22:29
@mcvinci mcvinci marked this pull request as ready for review March 31, 2022 22:41
@github-actions
Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset.
If the changes are user-facing and should cause a version bump, run "yarn changeset add" to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to examples or documentation, you do not need to add a changeset.

wizardlyhel
wizardlyhel approved these changes Apr 1, 2022
View reviewed changes
Copy link
Collaborator

@wizardlyhel wizardlyhel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from that rename comment, everything looks good

@wizardlyhel
Copy link
Collaborator

Do you think this flow chart would be useful in this doc?

Analytic data flow diagram

Screen Shot 2022-04-01 at 12 53 12 PM

@mcvinci
Copy link
Contributor Author

mcvinci commented Apr 8, 2022

@wizardlyhel I think it would be useful! I can look into incorporating that as part of the doc.

@blittle blittle force-pushed the v1.x-2022-07 branch 2 times, most recently from 2976ae8 to 13376ef Compare April 11, 2022 15:27
wizardlyhel
wizardlyhel requested changes Apr 11, 2022
View reviewed changes
packages/hydrogen/src/framework/docs/analytics.md Outdated Show resolved Hide resolved
packages/hydrogen/src/framework/docs/analytics.md Outdated Show resolved Hide resolved
packages/hydrogen/src/framework/docs/analytics.md Outdated Show resolved Hide resolved
@mcvinci mcvinci force-pushed the hydrogen-analytics-docs branch from 1c762d8 to 1247d92 Compare April 11, 2022 19:20
@mcvinci mcvinci requested a review from wizardlyhel April 11, 2022 19:21
wizardlyhel
wizardlyhel approved these changes Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@wizardlyhel wizardlyhel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mcvinci mcvinci merged commit 9348388 into v1.x-2022-07 Apr 11, 2022
@mcvinci mcvinci deleted the hydrogen-analytics-docs branch April 11, 2022 19:52
blittle added a commit that referenced this pull request Apr 11, 2022
@blittle
Merge branch 'v1.x-2022-07' into fix-main
a37805e 
* v1.x-2022-07:
  [Hydrogen docs]: Analytics (#962)
  Analytics (#890)
blittle added a commit that referenced this pull request Apr 11, 2022
@blittle
Merge branch 'v1.x-2022-07' into jl-node-16
c2ed088 
* v1.x-2022-07:
  [Hydrogen docs]: Analytics (#962)
  Analytics (#890)
  Allow line breaks inside script tags (#1061)
  Fix encoding of CSS Modules to solve hydration errors (#1062)
  [Hydrogen docs]: Update guidance on troubleshooting third-party dependencies (#1055)
  Update Vite RSC Plugin (#1054)
  Fix link prefetch (#1059)
  Initial devTools component (#998)
  Support sub request cache control header `stale-while-revalidate` everywhere (#1049)
  Fix cookie parsing (#1046)
  Update 3-external-images-with-a-custom-loader.example.tsx (#1045)
  Restore scroll position on browser navigation (#1047)
  Remove old changeset to unblock release (#1042)
  [ci] release v1.x-2022-07 (#1019)
  Update to Vite 2.9 (#1039)
  Use lang directive (#1028)
blittle added a commit that referenced this pull request Apr 19, 2022
@blittle
Merge branch 'v1.x-2022-07' into jl-persisted-state
b7113d8 
* v1.x-2022-07: (37 commits)
  Adds Shopify/hydrogen-cli for development server (#1089)
  Make `useUrl()` reactive for subscribing to navigation events (#1082)
  fix e2e tests
  streaming and suspense draft (#1033)
  [Hydrogen docs]: Restructure and simplify IA (#1079)
  Use new storefront API headers in queryShop API helper (#1075)
  Remove the dep of hydrogen-ui for now until we get it publishing (#1076)
  [ci] release v1.x-2022-07 (#1048)
  Introduce a synchronous-looking version of fetch for server and client (#983)
  improve the current type of ShopifyContextValue to be based on ShopifyConfig (#1072)
  Foundational work to split hydrogen-ui to its own package (#1060)
  Allow returning new requests from API routes (#1057)
  [Hydrogen docs]: Analytics (#962)
  Analytics (#890)
  Allow line breaks inside script tags (#1061)
  Fix encoding of CSS Modules to solve hydration errors (#1062)
  [Hydrogen docs]: Update guidance on troubleshooting third-party dependencies (#1055)
  Update Vite RSC Plugin (#1054)
  Fix link prefetch (#1059)
  Initial devTools component (#998)
  ...
@grichards
Copy link

Hello.

I've set up a vanilla "Demo Store - Typescript"... followed the first part of this tutorial "Subscribe to an Event"... and expected the "payload" to be logged to the console... but nothing got logged.

Has this tutorial been recently tested against the Demo Store? I can't get anything to log following this tutorial, nor using the EventsListener.client.tsx which is already built into the Demo Store.

I don't doubt I'm doing something wrong and/or having a fundamental misunderstanding...

TY!

@mcvinci
Copy link
Contributor Author

mcvinci commented Sep 29, 2022

Hey @wizardlyhel! 👋 Would you be able to help out @grichards with the question above, and work with Ren on any docs updates that are required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wizardlyhel wizardlyhel wizardlyhel approved these changes

Assignees

@mcvinci mcvinci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcvinci @wizardlyhel @grichards