-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inlay hint for omitted hash values #1186
Add inlay hint for omitted hash values #1186
Conversation
d0c42bb
to
964c42f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
- Add test using hash with slightly more complex formatting - Cleanup Co-authored-by: Alexandre Terrasa <[email protected]> Co-authored-by: Vinicius Stock <[email protected]>
ffc1277
to
3d44258
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There's currently no way to configure inlay hints with that level of granularity. We still need to accept a more complex configuration for it. |
Please add a configuration option, this is infuriating and unwanted. The whole point was to make code more clean and concise, it's frustrating that it was undone with this change. |
Can we make a new issue for a configuration option here? |
It's already being worked on as part of #834, which is related. |
Motivation
In this discussion, @andyw8 mentions how we could add an inlay hint for an omitted hash value to be a bit clearer about what's going on.
Implementation
rescue StandardError
worksnode.value
could be when thenode
is anImplicitNode
but let me know if I'm missing anythingAutomated Tests
I added some expectation tests!
Manual Tests
You could test this by opening the
ruby-lsp
project in VS code, restart the extension so it loads the development version, and then write some code with implied hash values. This should do it:Also
❤️