Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate .npmingore discrepancies between packages #1032

Merged
merged 2 commits into from
May 20, 2022
Merged

Investigate .npmingore discrepancies between packages #1032

merged 2 commits into from
May 20, 2022

Conversation

sc-nikolaoslazaridis
Copy link
Contributor

Description / Motivation

  • Deleted .npmignore files and added files array to package.json
  • Renamed testData folders to test-data.

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@sc-nikolaoslazaridis sc-nikolaoslazaridis requested a review from a team May 20, 2022 08:11
illiakovalenko
illiakovalenko approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

@illiakovalenko illiakovalenko merged commit f1fd3f1 into Sitecore:dev May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sc-nikolaoslazaridis @illiakovalenko