Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate .npmingore discrepancies between packages #1032

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/sitecore-jss-angular-schematics/.nycrc
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"exclude": [
"**/*.d.ts",
"**/*.test.ts",
"src/testData",
"src/test-data",
"dist",
"src/test.ts"
],
Expand Down
18 changes: 0 additions & 18 deletions packages/sitecore-jss-angular/.npmignore

This file was deleted.

6 changes: 5 additions & 1 deletion packages/sitecore-jss-angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,5 +71,9 @@
"es2015_ivy_ngcc": "dist/__ivy_ngcc__/fesm2015/sitecore-jss-sitecore-jss-angular.js",
"fesm2015_ivy_ngcc": "dist/__ivy_ngcc__/fesm2015/sitecore-jss-sitecore-jss-angular.js",
"sideEffects": false,
"gitHead": "2f4820efddf4454eeee58ed1b2cc251969efdf5b"
"gitHead": "2f4820efddf4454eeee58ed1b2cc251969efdf5b",
"files": [
"dist",
"typings"
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { DatePipe, formatDate } from '@angular/common';
import { Component, DebugElement, Input } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { By } from '@angular/platform-browser';
import { textField as eeTextData } from '../testData/ee-data';
import { textField as eeTextData } from '../test-data/ee-data';
import { DateDirective } from './date.directive';
import { TextField } from './rendering-field';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Component, DebugElement, Input } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { By } from '@angular/platform-browser';

import { generalLinkField as eeLinkData } from '../testData/ee-data';
import { generalLinkField as eeLinkData } from '../test-data/ee-data';
import { GenericLinkDirective } from './generic-link.directive';
import { RouterTestingModule } from '@angular/router/testing';
import { Router } from '@angular/router';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Component, DebugElement, Input } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { By } from '@angular/platform-browser';

import { imageField as eeImageData } from '../testData/ee-data';
import { imageField as eeImageData } from '../test-data/ee-data';
import { ImageDirective } from './image.directive';
import { ImageField } from './rendering-field';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Component, DebugElement, Input } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { By } from '@angular/platform-browser';

import { generalLinkField as eeLinkData } from '../testData/ee-data';
import { generalLinkField as eeLinkData } from '../test-data/ee-data';
import { LinkDirective } from './link.directive';
import { LinkField } from './rendering-field';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ import { SpyNgModuleFactoryLoader } from '@angular/router/testing';

import { JssModule } from '../lib.module';

import { convertedData as eeData } from '../testData/ee-data';
import { convertedData as eeData } from '../test-data/ee-data';
import {
convertedDevData as nonEeDevData,
convertedLayoutServiceData as nonEeLsData,
} from '../testData/non-ee-data';
} from '../test-data/non-ee-data';

@Component({
selector: 'test-placeholder',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Component, DebugElement, Input } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { By } from '@angular/platform-browser';

import { richTextField as eeRichTextData } from '../testData/ee-data';
import { richTextField as eeRichTextData } from '../test-data/ee-data';
import { RichTextField } from './rendering-field';
import { RichTextDirective } from './rich-text.directive';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Component, DebugElement, Input } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { By } from '@angular/platform-browser';

import { generalLinkField as eeLinkData } from '../testData/ee-data';
import { generalLinkField as eeLinkData } from '../test-data/ee-data';
import { RouterLinkDirective } from './router-link.directive';
import { RouterTestingModule } from '@angular/router/testing';
import { LinkField } from './rendering-field';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Component, DebugElement, Input } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { By } from '@angular/platform-browser';

import { textField as eeTextData } from '../testData/ee-data';
import { textField as eeTextData } from '../test-data/ee-data';
import { TextField } from './rendering-field';
import { TextDirective } from './text.directive';

Expand Down
15 changes: 0 additions & 15 deletions packages/sitecore-jss-cli/.npmignore

This file was deleted.

2 changes: 1 addition & 1 deletion packages/sitecore-jss-cli/.nycrc
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"exclude": [
"**/*.d.ts",
"**/*.test.ts",
"src/testData",
"src/test-data",
"dist",
"src/test.ts"
],
Expand Down
6 changes: 5 additions & 1 deletion packages/sitecore-jss-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,5 +63,9 @@
"ts-node": "^8.4.1",
"typescript": "~4.3.5"
},
"gitHead": "2f4820efddf4454eeee58ed1b2cc251969efdf5b"
"gitHead": "2f4820efddf4454eeee58ed1b2cc251969efdf5b",
"files": [
"dist",
"types"
]
}
16 changes: 0 additions & 16 deletions packages/sitecore-jss-dev-tools/.npmignore

This file was deleted.

2 changes: 1 addition & 1 deletion packages/sitecore-jss-dev-tools/.nycrc
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"exclude": [
"**/*.d.ts",
"**/*.test.ts",
"src/**/testData",
"src/**/test-data",
"src/pipelines/test",
"dist",
"types"
Expand Down
6 changes: 5 additions & 1 deletion packages/sitecore-jss-dev-tools/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -87,5 +87,9 @@
"typescript": "~4.3.5"
},
"types": "types/index.d.ts",
"gitHead": "2f4820efddf4454eeee58ed1b2cc251969efdf5b"
"gitHead": "2f4820efddf4454eeee58ed1b2cc251969efdf5b",
"files": [
"dist",
"types"
]
}
2 changes: 1 addition & 1 deletion packages/sitecore-jss-dev-tools/src/digest.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { digest, hmac } from './digest';
describe('digest', () => {
describe('digest', () => {
it('should generate expected file hash', () => {
const inputPath = './src/testData/digest/hello.txt';
const inputPath = './src/test-data/digest/hello.txt';
return digest(inputPath).then((result) =>
expect(result).to.equal('uU0nuZNNPgilLlLX2n2r+sSE7+N6U4DukIj3rOLvzek=')
);
Expand Down
4 changes: 2 additions & 2 deletions packages/sitecore-jss-dev-tools/src/mergeFs.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ describe('merge files', () => {

describe('merge route data', () => {
it('should generate data without error', () => {
const inputPath = './src/testData/mergeFs/routes';
const inputPath = './src/test-data/mergeFs/routes';
return mergeFs(inputPath).then((result) => expect(result).to.not.be.undefined);
});
});

describe('merge non-route data', () => {
it('should generate data without error', () => {
const inputPath = './src/testData/mergeFs/non-routes';
const inputPath = './src/test-data/mergeFs/non-routes';
return mergeFs(inputPath).then((result) => expect(result).to.not.be.undefined);
});
});
Expand Down
16 changes: 0 additions & 16 deletions packages/sitecore-jss-forms/.npmignore

This file was deleted.

2 changes: 1 addition & 1 deletion packages/sitecore-jss-forms/.nycrc
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"exclude": [
"**/*.d.ts",
"**/*.test.ts",
"src/testData",
"src/test-data",
"dist",
"src/test.ts",
"src/index.ts",
Expand Down
6 changes: 5 additions & 1 deletion packages/sitecore-jss-forms/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,5 +48,9 @@
},
"description": "",
"types": "types/index.d.ts",
"gitHead": "2f4820efddf4454eeee58ed1b2cc251969efdf5b"
"gitHead": "2f4820efddf4454eeee58ed1b2cc251969efdf5b",
"files": [
"dist",
"types"
]
}
2 changes: 1 addition & 1 deletion packages/sitecore-jss-forms/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@
"dist",
"src/customTypes",
"src/**/*.test.ts",
"src/testData/*.ts"
"src/test-data/*.ts"
]
}
19 changes: 0 additions & 19 deletions packages/sitecore-jss-nextjs/.npmignore

This file was deleted.

2 changes: 1 addition & 1 deletion packages/sitecore-jss-nextjs/.nycrc
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"**/*.test.tsx",
"**/*.test.ts",
"src/tests",
"src/testData",
"src/test-data",
"dist",
"**/sharedTypes.ts"
],
Expand Down
8 changes: 7 additions & 1 deletion packages/sitecore-jss-nextjs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -78,5 +78,11 @@
},
"description": "",
"types": "types/index.d.ts",
"gitHead": "2f4820efddf4454eeee58ed1b2cc251969efdf5b"
"gitHead": "2f4820efddf4454eeee58ed1b2cc251969efdf5b",
"files": [
"dist",
"types",
"./*.js",
"./*.d.ts"
]
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { expect } from 'chai';
import { EditingData } from '../sharedTypes/editing-data';
import { EditingDataDiskCache } from './editing-data-cache';
import { data } from '../testData/editing-data';
import { data } from '../test-data/editing-data';

describe('EditingDataDiskCache', () => {
it('should write/read editing data', () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { AxiosDataFetcher } from '@sitecore-jss/sitecore-jss';
import { EditingDataService } from '../services/editing-data-service';
import { QUERY_PARAM_EDITING_SECRET } from '../services/editing-data-service';
import { EditingPreviewData } from '../sharedTypes/editing-data';
import { EE_PATH, EE_LANGUAGE, EE_LAYOUT, EE_DICTIONARY, EE_BODY } from '../testData/ee-data';
import { EE_PATH, EE_LANGUAGE, EE_LAYOUT, EE_DICTIONARY, EE_BODY } from '../test-data/ee-data';
import { EditingRenderMiddleware, extractEditingData } from './editing-render-middleware';
import { spy, match } from 'sinon';
import sinonChai from 'sinon-chai';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ import {
GraphQLSitemapServiceConfig,
languageError,
} from './graphql-sitemap-service';
import sitemapDefaultQueryResult from '../testData/sitemapDefaultQueryResult.json';
import sitemapPersonalizeQueryResult from '../testData/sitemapPersonalizeQueryResult.json';
import sitemapServiceResult from '../testData/sitemapServiceResult';
import sitemapDefaultQueryResult from '../test-data/sitemapDefaultQueryResult.json';
import sitemapPersonalizeQueryResult from '../test-data/sitemapPersonalizeQueryResult.json';
import sitemapServiceResult from '../test-data/sitemapServiceResult';
import { GraphQLClient, GraphQLRequestClient } from '@sitecore-jss/sitecore-jss/graphql';

class TestService extends GraphQLSitemapService {
Expand Down
2 changes: 1 addition & 1 deletion packages/sitecore-jss-nextjs/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"middleware.d.ts",
"edge.d.ts",
"src/tests/*",
"src/testData/*",
"src/test-data/*",
"**/*.test.ts",
"**/*.test.tsx"
]
Expand Down
16 changes: 0 additions & 16 deletions packages/sitecore-jss-proxy/.npmignore

This file was deleted.

6 changes: 5 additions & 1 deletion packages/sitecore-jss-proxy/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,5 +47,9 @@
"typescript": "~4.3.5"
},
"types": "types/index.d.ts",
"gitHead": "2f4820efddf4454eeee58ed1b2cc251969efdf5b"
"gitHead": "2f4820efddf4454eeee58ed1b2cc251969efdf5b",
"files": [
"dist",
"types"
]
}
2 changes: 1 addition & 1 deletion packages/sitecore-jss-proxy/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
"typeRoots": ["node_modules/@types"],
"declarationDir": "./types"
},
"exclude": ["node_modules", "types", "dist", "src/**/*.test.ts", "src/testData/*.ts"]
"exclude": ["node_modules", "types", "dist", "src/**/*.test.ts", "src/test-data/*.ts"]
}
16 changes: 0 additions & 16 deletions packages/sitecore-jss-react-forms/.npmignore

This file was deleted.

Loading