Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react][nextjs] Fix double hash in anchor links #1375

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

art-alexeyenko
Copy link
Contributor

Description / Motivation

Fixes an issue where 'anchor' type links would be incorrectly rendered.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team March 10, 2023 15:14
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@ambrauer ambrauer merged commit 26fc411 into dev Mar 13, 2023
@ambrauer ambrauer deleted the bug/no-hash-in-links-react branch March 13, 2023 16:08
art-alexeyenko added a commit that referenced this pull request Mar 15, 2023
Add the fix for double hash links (#1375) into JSS v19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants