Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix] Fix #573146 on top of JSS 19 #1376

Merged
merged 1 commit into from
Mar 15, 2023
Merged

[Hotfix] Fix #573146 on top of JSS 19 #1376

merged 1 commit into from
Mar 15, 2023

Conversation

art-alexeyenko
Copy link
Contributor

Description / Motivation

Add the fix for double hash links (#1375) into JSS v19.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team March 13, 2023 18:12
ambrauer
ambrauer approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please take a look at CI checks which are failing

@art-alexeyenko art-alexeyenko merged commit 565b4c9 into release/19.0.0 Mar 15, 2023
@art-alexeyenko art-alexeyenko deleted the hotfix/573146 branch March 15, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@art-alexeyenko @ambrauer