Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss][nextjs] Use site query to retrieve dictionary data in XMCloud #1804

Merged
merged 12 commits into from
Jul 18, 2024
Merged

[sitecore-jss][nextjs] Use site query to retrieve dictionary data in XMCloud #1804

merged 12 commits into from
Jul 18, 2024

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented May 23, 2024 •
edited
Loading

  • This PR follows the Contribution Guide
  • Changelog updated
  • Upgrade guide entry added - TBD

Description / Motivation

Switching dictionary service from using slower search queries to faster site GraphQL query.

  • Only enabled on XM Cloud
  • DictionaryService was the last place to use SearchQueryService. With this PR, SearchQueryService is marked obsolete and should be removed once site query can be enabled for both XMC and SXP.
  • To be merged once Edge schema changes are live

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team May 23, 2024 21:27
illiakovalenko
illiakovalenko approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approved
See few minor comments below

CHANGELOG.md Outdated Show resolved Hide resolved
packages/sitecore-jss/src/i18n/graphql-dictionary-service.ts Outdated Show resolved Hide resolved
@art-alexeyenko art-alexeyenko requested a review from ambrauer May 29, 2024 16:20
ambrauer
ambrauer approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@art-alexeyenko art-alexeyenko mentioned this pull request Jun 19, 2024
Merged
9 tasks
@art-alexeyenko
Merge branch 'dev' of https://github.com/Sitecore/jss into feature/js…
b85b67f 
…s-1867-dictionary-schema-update

# Conflicts:
#	docs/upgrades/unreleased.md
@art-alexeyenko
prepare for gql schema changes
abe8643
@art-alexeyenko art-alexeyenko mentioned this pull request Jun 28, 2024
Merged
8 tasks
@illiakovalenko illiakovalenko merged commit 7dea463 into dev Jul 18, 2024
1 check passed
@illiakovalenko illiakovalenko deleted the feature/jss-1867-dictionary-schema-update branch July 18, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

@ambrauer ambrauer ambrauer approved these changes

@addy-pathania addy-pathania Awaiting requested review from addy-pathania

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@art-alexeyenko @ambrauer @illiakovalenko @addy-pathania