Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react][nextjs] Extra upgrade hotfix prep #1833

Merged
merged 1 commit into from
Jul 3, 2024
Merged

[react][nextjs] Extra upgrade hotfix prep #1833

merged 1 commit into from
Jul 3, 2024

Conversation

art-alexeyenko
Copy link
Contributor

Description / Motivation

Follow up to #1804 to address issues found in testing of the upgrades.

  • Remove url-parse dependency from react sample to avoid npm conflicts with webpack.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team June 28, 2024 21:21
@illiakovalenko illiakovalenko merged commit 97952b1 into release/20.0.0 Jul 3, 2024
1 check passed
@illiakovalenko illiakovalenko deleted the hotfix/20.0.0/jss-3453-cleanup branch July 3, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@art-alexeyenko @illiakovalenko