[sitecore-jss] [sitecore-jss-nextjs] Pass sc_layoutKind to grapqhl layout request header.
#1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illiakovalenko
requested changes
Aug 26, 2024
...sitecore-jss/src/templates/nextjs-xmcloud/src/lib/page-props-factory/plugins/preview-mode.ts
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/editing/editing-render-middleware.ts
Outdated
Show resolved
Hide resolved
illiakovalenko
requested changes
Aug 27, 2024
packages/sitecore-jss/src/editing/graphql-editing-service.test.ts
Outdated
Show resolved
Hide resolved
...sitecore-jss/src/templates/nextjs-xmcloud/src/lib/page-props-factory/plugins/preview-mode.ts
Show resolved
Hide resolved
8 tasks
Co-authored-by: Illia Kovalenko <[email protected]>
Co-authored-by: Illia Kovalenko <[email protected]>
Co-authored-by: Illia Kovalenko <[email protected]>
illiakovalenko
approved these changes
Aug 27, 2024
packages/sitecore-jss/src/editing/graphql-editing-service.test.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss/src/editing/graphql-editing-service.test.ts
Outdated
Show resolved
Hide resolved
…ecore/jss into feature/jss-3978-layout-kind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
In order to support shared vs final layout switcher, we need to pass type of layout to CM when render through horizon.
sc_layoutKindextends/editing/rendercontract.LayoutKindwhich can have valuesharedorfinalfinaloptionsparam to pass dynamic values like headers etc.Testing Details
Types of changes