Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[templates/angular] Update angular template to support deployment to xmcloud #1977

Merged
merged 6 commits into from
Nov 20, 2024
Merged

[templates/angular] Update angular template to support deployment to xmcloud #1977

merged 6 commits into from
Nov 20, 2024

Conversation

yavorsk
Copy link
Contributor

@yavorsk yavorsk commented Nov 18, 2024

Description / Motivation

The updates in this PR are done to allow deployment of angular spa starter plus proxy apps to xmcloud:

  • adds reflect-metadata dependency
  • updates npm-run-all dependency to npm-run-all2
  • ensure PROXY_BUILD_PATH value is a unix style path (with forward slashes); this allows compatibility with both windows and unix style sysetems

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@yavorsk yavorsk changed the title [templates/angular] Update angular template to work well with xmcloud deployment [templates/angular] Update angular template to work with xmcloud deployment Nov 18, 2024
@yavorsk yavorsk changed the title [templates/angular] Update angular template to work with xmcloud deployment [templates/angular] Update angular template to support deployment to xmcloud Nov 18, 2024
illiakovalenko
illiakovalenko approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Just one minor comment below related to changelog

CHANGELOG.md Outdated Show resolved Hide resolved
art-alexeyenko
art-alexeyenko approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@art-alexeyenko art-alexeyenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work, thank you Yavor!
My concerns are no longer and my heart is calm :)

@yavorsk yavorsk merged commit d6bdb5a into dev Nov 20, 2024
1 check passed
@yavorsk yavorsk deleted the feature/jss-4211 branch November 20, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

@art-alexeyenko art-alexeyenko art-alexeyenko approved these changes

@addy-pathania addy-pathania Awaiting requested review from addy-pathania

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yavorsk @art-alexeyenko @illiakovalenko