Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[templates/angular] Update angular template to support deployment to xmcloud #1977

Merged
merged 6 commits into from
Nov 20, 2024
Merged

[templates/angular] Update angular template to support deployment to xmcloud #1977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f7193de
Add reflect-metadata and npm-run-all2 dependency to angular template …
yavorsk Nov 18, 2024
26cc266
Update PROXY_BUILD_PATH to use a relative unix style path
yavorsk Nov 18, 2024
a890b8d
update changelog
yavorsk Nov 18, 2024
94367fa
update npm-run-all2 to latest
yavorsk Nov 19, 2024
379038b
Update CHANGELOG entry text
yavorsk Nov 19, 2024
06cde02
Merge branch 'dev' into feature/jss-4211
yavorsk Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ Our versioning strategy is as follows:
* `[angular-xmcloud]` Add CloudSDK initialization on client side ([#1952](https://github.com/Sitecore/jss/pull/1952))([#1957](https://github.com/Sitecore/jss/pull/1957))([#1961](https://github.com/Sitecore/jss/pull/1961))
* `[angular-xmcloud]``[sitecore-jss-angular]` Add CDP Page View component to Angular XM Cloud add-on ([#1957](https://github.com/Sitecore/jss/pull/1957))
* `[templates/vue]``[sitecore-jss-vue]` Vue version has been updated to 3.5
* `[templates/angular]` Update dependencies and proxy build path value to be unix style path to support xmcloud deployment and monorepo starter kit in xmcloud foundation head ([#1977](https://github.com/Sitecore/jss/pull/1977))


### 🛠 Breaking Change
Expand Down
5 changes: 3 additions & 2 deletions packages/create-sitecore-jss/src/templates/angular-xmcloud/.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,12 @@ SITECORE_EDGE_CONTEXT_ID=
PROXY_HOST=http://localhost:3000

# Your XM Cloud Proxy server path is needed to build the app. The build output will be copied to the proxy server path.
PROXY_BUILD_PATH=<%- locals.relativeProxyAppDestination.replace(/\\/g, '\\\\') %>dist
# Use a relative unix style path to ensure compatibility when deployment runs on Windows or Unix based systems.
PROXY_BUILD_PATH=<%- locals.relativeProxyAppDestination.replace(/\\/g, '\/') %>dist
art-alexeyenko marked this conversation as resolved.
Show resolved Hide resolved

# ==============================================

# An optional Sitecore Personalize scope identifier.
# This can be used to isolate personalization data when multiple XM Cloud Environments share a Personalize tenant.
# This should match the PAGES_PERSONALIZE_SCOPE environment variable for your connected XM Cloud Environment.
PERSONALIZE_SCOPE=
PERSONALIZE_SCOPE=
5 changes: 3 additions & 2 deletions packages/create-sitecore-jss/src/templates/angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@
"graphql-tag": "~2.11.0",
"rxjs": "~7.8.1",
"tslib": "^2.6.3",
"zone.js": "~0.14.7"
"zone.js": "~0.14.7",
"reflect-metadata": "^0.2.2"
},
"devDependencies": {
"@angular-builders/custom-webpack": "^17.0.2",
Expand Down Expand Up @@ -107,7 +108,7 @@
"karma-jasmine": "~4.0.1",
"karma-jasmine-html-reporter": "~1.5.4",
"move-cli": "^2.0.0",
"npm-run-all": "~4.1.5",
"npm-run-all2": "^7.0.1",
"protractor": "^7.0.0",
"ts-node": "~10.9.2",
"typescript": "~5.2.2"
Expand Down