Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate TSLint to ESLint #517

Merged
merged 40 commits into from
Dec 23, 2020
Merged

Migrate TSLint to ESLint #517

merged 40 commits into from
Dec 23, 2020

Conversation

sc-illiakovalenko
Copy link
Contributor

@sc-illiakovalenko sc-illiakovalenko commented Dec 21, 2020 •
edited
Loading

Description

Motivation

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update (non-breaking change; modified files are limited to the /docs directory)

Checklist:

  • I have read the Contributing guide.
  • My code follows the code style of this project.
  • My code/comments/docs fully adhere to the Code of Conduct.
  • My change is a code change and it requires an update to the documentation.
  • My change is a documentation change and it requires an update to the navigation.

@illiakovalenko
configure sitecore-jss-react
f9d7f3e
@illiakovalenko
Push
540f8c5
@illiakovalenko
Merge branch 'dev' of https://github.com/Sitecore/jss into feature/44…
2aad7c6 
…7933
@illiakovalenko
Lint sitecore-jss-nextjs
32dbce5
@illiakovalenko
lint sitecore-jss-react-native
5bd7325
@illiakovalenko
Merge branch 'dev' of https://github.com/Sitecore/jss into feature/44…
56bdaf4 
…7933
@illiakovalenko
push
0d96430
@illiakovalenko
lint cli
49c7155
@illiakovalenko
Push dev-tools
5ad0b78
@illiakovalenko
push sitecore-jss-forms
229ac17
@illiakovalenko
push sitecore-jss-manifest
a76588b
@illiakovalenko
push proxy
92f545f
@illiakovalenko
Push default eslintrc
43ef4ac
@illiakovalenko
push react-forms
9ce1ded
@illiakovalenko
push sitecore-jss-react-native
215fa8f
@illiakovalenko
push jss-rendering-host
7d63616
@illiakovalenko
push jss-tracking
14f51fb
@illiakovalenko
push update-package
4ddb0b4
@illiakovalenko
push sitecore-jss-vue
aad748d
@illiakovalenko
push sitecore-pipelines
588a3e9
@illiakovalenko
push sitecore-jss-angular
8f4f383
@illiakovalenko
push root
2149053
@illiakovalenko
Merge branch 'dev' of https://github.com/Sitecore/jss into feature/44…
6d46610 
…7933
@illiakovalenko
push sitecore-jss-nextjs
47c1dea
@illiakovalenko
push sitecore jss next js editing host
40c8c93
@illiakovalenko
push
5eb06b2
@illiakovalenko
push react-native sample
779f67f
@illiakovalenko
Update angular sample
592569f
@illiakovalenko
push package locks
9528e45
sc-illiakovalenko
sc-illiakovalenko commented Dec 21, 2020
View reviewed changes
packages/sitecore-jss-react-native/src/components/sharedTypes.ts

export type ComponentFactory = (componentName: string) => Component;
export type ComponentFactory = (componentName: string) => ComponentType | null;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a breaking change, but it's valid, because Component can't be Class or FunctionComponent

@sc-illiakovalenko sc-illiakovalenko changed the title Feature/447933 Migrate TSLint to ESLint Dec 21, 2020
ambrauer
ambrauer suggested changes Dec 21, 2020
View reviewed changes
.eslintrc Outdated Show resolved Hide resolved
.eslintrc Outdated Show resolved Hide resolved
.eslintrc Outdated Show resolved Hide resolved
.eslintrc Outdated Show resolved Hide resolved
.eslintrc Outdated Show resolved Hide resolved
.eslintrc Outdated Show resolved Hide resolved
packages/sitecore-jss-vue/.eslintrc Outdated Show resolved Hide resolved
packages/sitecore-pipelines/.eslintrc Outdated Show resolved Hide resolved
samples/react-native/.eslintrc.json Show resolved Hide resolved
samples/react/.eslintrc Outdated Show resolved Hide resolved
@sc-illiakovalenko sc-illiakovalenko merged commit 19954b1 into dev Dec 23, 2020
@sc-illiakovalenko sc-illiakovalenko deleted the feature/447933 branch December 23, 2020 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sc-illiakovalenko @ambrauer @illiakovalenko