Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate TSLint to ESLint #517

Merged
merged 40 commits into from
Dec 23, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
f9d7f3e
configure sitecore-jss-react
illiakovalenko Dec 14, 2020
540f8c5
Push
illiakovalenko Dec 15, 2020
2aad7c6
Merge branch 'dev' of https://github.com/Sitecore/jss into feature/44…
illiakovalenko Dec 16, 2020
32dbce5
Lint sitecore-jss-nextjs
illiakovalenko Dec 16, 2020
5bd7325
lint sitecore-jss-react-native
illiakovalenko Dec 16, 2020
56bdaf4
Merge branch 'dev' of https://github.com/Sitecore/jss into feature/44…
illiakovalenko Dec 17, 2020
0d96430
push
illiakovalenko Dec 17, 2020
49c7155
lint cli
illiakovalenko Dec 17, 2020
5ad0b78
Push dev-tools
illiakovalenko Dec 17, 2020
229ac17
push sitecore-jss-forms
illiakovalenko Dec 17, 2020
a76588b
push sitecore-jss-manifest
illiakovalenko Dec 17, 2020
92f545f
push proxy
illiakovalenko Dec 17, 2020
43ef4ac
Push default eslintrc
illiakovalenko Dec 17, 2020
9ce1ded
push react-forms
illiakovalenko Dec 18, 2020
215fa8f
push sitecore-jss-react-native
illiakovalenko Dec 18, 2020
7d63616
push jss-rendering-host
illiakovalenko Dec 18, 2020
14f51fb
push jss-tracking
illiakovalenko Dec 18, 2020
4ddb0b4
push update-package
illiakovalenko Dec 18, 2020
aad748d
push sitecore-jss-vue
illiakovalenko Dec 18, 2020
588a3e9
push sitecore-pipelines
illiakovalenko Dec 18, 2020
8f4f383
push sitecore-jss-angular
illiakovalenko Dec 18, 2020
2149053
push root
illiakovalenko Dec 18, 2020
6d46610
Merge branch 'dev' of https://github.com/Sitecore/jss into feature/44…
illiakovalenko Dec 18, 2020
47c1dea
push sitecore-jss-nextjs
illiakovalenko Dec 18, 2020
40c8c93
push sitecore jss next js editing host
illiakovalenko Dec 18, 2020
5eb06b2
push
illiakovalenko Dec 18, 2020
779f67f
push react-native sample
illiakovalenko Dec 18, 2020
592569f
Update angular sample
illiakovalenko Dec 21, 2020
9528e45
push package locks
illiakovalenko Dec 21, 2020
320f087
push rule
illiakovalenko Dec 21, 2020
5d19d0c
push with prettier
illiakovalenko Dec 21, 2020
c8c7480
push lock
illiakovalenko Dec 21, 2020
57c4ff9
remove eslint plugins from jss-react
illiakovalenko Dec 21, 2020
646652d
Fix react props
illiakovalenko Dec 21, 2020
c8d5246
Add eslint-plugin-jsdoc
illiakovalenko Dec 22, 2020
2220eb7
enable `@typescript-eslint/explicit-module-boundary-types` - rule
illiakovalenko Dec 22, 2020
fb113cd
Push changes
illiakovalenko Dec 22, 2020
2114185
push locks
illiakovalenko Dec 22, 2020
f1c019c
Add upgrade guide step
illiakovalenko Dec 22, 2020
b384ee0
Changes after review
illiakovalenko Dec 22, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
81 changes: 62 additions & 19 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -1,31 +1,74 @@
{
"root": true,
"parser": "babel-eslint",
"extends": ["airbnb-base", "prettier", "plugin:import/errors", "plugin:import/warnings"],
"extends": [
"eslint:recommended",
"plugin:@typescript-eslint/recommended",
"plugin:jsdoc/recommended",
"prettier",
"prettier/@typescript-eslint"
],
"parser": "@typescript-eslint/parser",
"parserOptions": {
"ecmaFeatures": {
"jsx": true
},
"ecmaVersion": 2020,
"sourceType": "module"
},
"plugins": ["@typescript-eslint", "prettier", "jsdoc"],
"env": {
"browser": true,
"node": true,
"es6": true
},
"rules": {
"jsdoc/newline-after-description": "off",
"jsdoc/require-property-description": "off",
"jsdoc/require-param-description": "off",
"jsdoc/require-returns": "off",
"jsdoc/no-undefined-types": "off",
"jsdoc/require-returns-type": "off",
"prettier/prettier": "error",
"import/prefer-default-export": "off",
"import/no-extraneous-dependencies": [
"@typescript-eslint/naming-convention": [
"error",
{
"devDependencies": true,
"optionalDependencies": true
"format": ["PascalCase"],
"selector": "typeLike",
"custom": {
"regex": "^I[A-Z]",
"match": false
}
}
],
"linebreak-style": ["error", "windows"],
"arrow-body-style": ["warn", "as-needed"],
"arrow-parens": ["error", "always"],
"no-unused-vars": [
"@typescript-eslint/member-ordering": "error",
"no-use-before-define": "off",
"@typescript-eslint/no-use-before-define": [
"error",
{
"args": "none"
}
{ "functions": false, "variables": false }
],
"radix": ["error", "as-needed"],
"prefer-destructuring": "off"
},
"plugins": ["import", "prettier"],
"settings": {
"import/ignore": ["node_modules", ".png$", ".jpg$"]
"@typescript-eslint/typedef": "error",
"@typescript-eslint/type-annotation-spacing": "error",
"@typescript-eslint/semi": "error",
"@typescript-eslint/no-var-requires": "off",
"no-useless-escape": "off",
"spaced-comment": "error",
"curly": ["error", "multi-line"],
"eol-last": ["error", "always"],
"guard-for-in": "error",
"no-unused-labels": "error",
"no-caller": "error",
"no-bitwise": "error",
"no-multiple-empty-lines": "error",
"no-new-wrappers": "error",
"no-eval": "error",
"dot-notation": "error",
"no-trailing-spaces": "error",
"no-unused-expressions": ["error", { "allowShortCircuit": true, "allowTernary": true }],
"brace-style": "error",
"quotes": ["error", "single"],
"radix": "error",
"default-case": "error",
"eqeqeq": "error",
"jsx-quotes": ["error", "prefer-double"]
}
}
9 changes: 9 additions & 0 deletions docs/data/routes/upgrade-guides/16.0/en.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
name: "16.0"
routeTemplate: ./data/component-templates/full-page.yml
title: Upgrading to JSS 16.0
---

### Upgrading from JSS 15.0 to JSS 16.0

1. Check usages of `any` type (and fix any build/lint errors) as we start to migrate from `any` to `unknown` or more specific types
Loading