patchsets: Make virtual diff target with shared history #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we just made the first virtual diff target with no parent
resulting in a branch with no shared history with any other
branch. Strictly this shouldn't matter as we only use the
branch for diffs, but we've seen a few cases where pushing this
branch is specifically causing git push to take an incredibly
long time. I don't have a great way to explain this as the virtual
diff target should only be pushing the tree itself, all blobs within
it reuse blobs that were already present in the repo.
Try to create the target with a shared history from an
arbitrary commit to see if this resolves the issues we see.
Topic: vritdiff
Reviewers: brian-k