Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patchsets: Make virtual diff target with shared history #81

Merged
merged 1 commit into from
Jan 11, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions revup/topic_stack.py
Original file line number Diff line number Diff line change
@@ -303,6 +303,8 @@ async def create_patchsets_comment(
diff_base = review.base_ref
elif review.base_ref != review.pr_info.baseRefOid:
# Rebased review, make a virtual diff target
if self.last_virtual_diff_target is None:
self.last_virtual_diff_target = GitCommitHash(self.base_branch)
self.last_virtual_diff_target = await self.git_ctx.make_virtual_diff_target(
review.pr_info.baseRefOid,
review.pr_info.headRefOid,