Main Screen & Review w/ Dummy Cards #2
Conversation
…n cycle through the cards in that deck in the review screen. Back button now sends back to home screen
prisma/schema.prisma
Outdated
| @@ -12,12 +12,24 @@ generator client { | |||
| previewFeatures = ["referentialIntegrity"] | |||
| } | |||
|
|
|||
| model Card { | |||
| id Int @default(autoincrement()) @id | |||
| model DxDeck { | |||
There was a problem hiding this comment.
The Dx prefix on Card and Deck was just for your experimentation, right?
There was a problem hiding this comment.
Yes! I'll change these to simply "Card" and "Deck" and re-push.
src/backend/router/index.ts
Outdated
| input: z | ||
| .object({ | ||
| text: z.string().nullish(), | ||
| }) | ||
| .nullish(), | ||
| async resolve({ input }) { |
There was a problem hiding this comment.
should we just get rid of this input for now?
There was a problem hiding this comment.
Tested locally. Works fine without any input! Down to delete for now.
| import NextError from "next/error"; | ||
| import Link from "next/link"; | ||
|
|
||
| export default function Review() { |
There was a problem hiding this comment.
do you think we'll have a page at deck/[id] with a different purpose? Wondering if we just use that versus review
There was a problem hiding this comment.
Good question! The idea was that "review" would be an execution of the deck.
Possibilities in the future
/deck/[id]-> An overview of your deck where you can look at all the cards in a list view and edit/add/card/[id]-> An editing page for a card?
I noticed that you had a "new" page in your branch. That seems perfectly clear! /edit/[id] could certainly be embedded to make things work perfectly fine. I'm not particularly hung up on any particular naming convention, but switched to "review" to make the use a little more clear than "deck" which I figured could have multiple interpretations.
That being said, I'm down to change to anything that makes sense and can be expanded upon!
@nleech16 @tliebert Thoughts?
| @@ -8,7 +8,7 @@ | |||
| "forceConsistentCasingInFileNames": true, | |||
| "noEmit": true, | |||
| "esModuleInterop": true, | |||
| "module": "esnext", | |||
| "module": "commonjs", | |||
There was a problem hiding this comment.
Curious as to what prompted the change to commonjs from esnext.
There was a problem hiding this comment.
Good question! I was running into the following error trying to run npx prisma db seed.
It looks like the seed command utilizes ts-node, which requires commonjs from my understanding.
…refactored DxDeck and DxCard to Deck and Card across the app
First set of changes to match the UI with the Figma design.