use font-loader instead of andrew's fontconfig #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elinorbgr
force-pushed
the
font-loader
branch
2 times, most recently
from
de22104 to
9b49225
Compare
|
What was the reason |
|
fontconfig is a lower-level dependency (font-loader depends on it), and font-loader appears to be mostly unmaintained now. |
|
I missed that somehow, sorry. |
|
I was not aware of it, will have to give it a look. Thanks for the heads-up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes SCTK's logic to use font-loader instead of the in-house fontconfig logic of andrew to find & load fonts. font-loader uses the fontconfig library, so this should hopefully fix most font loading issues.
This is a hotfix measure in waiting for something like #131 to move forward.
Should fix #170