Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raqote (andrew replacement) [WIP] #131

Closed
wants to merge 1 commit into from

Conversation

trimental
Copy link
Contributor

Here's a work in progress PR to use raqote instead of andrew. There's a few issues such as non native endian and screen flickering (probably due to not writing directly to the memory map) to address.

@@ -16,7 +16,9 @@ nix = "0.17"
dlib = "0.4"
lazy_static = "1.0"
memmap = "0.7"
andrew = { version = "0.3.0", optional = true }
raqote = "0.8"
font-kit = "0.7"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be ware of font-kit, it'll start linking to system libs, also font-kit isn't something that works on linux, since it's lacking font fallback and you won't be able to naturally handle certain things.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a) rusttype could be used directly.
b) font-kit's FAQ states it would welcome a PR that adds a rusttype backend.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can use fontdue here instead of font-kit?

@@ -16,7 +16,9 @@ nix = "0.17"
dlib = "0.4"
lazy_static = "1.0"
memmap = "0.7"
andrew = { version = "0.3.0", optional = true }
raqote = "0.8"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would nice if the drawing library remained optional. Some users of SCTK do not need decorations drawn by the library.

@trimental
Copy link
Contributor Author

Just a note that https://github.com/RazrFalcon/tiny-skia is something to watch for progress. It seems to be minimally dependent on other crates (hence the tiny), however the main issue is that text isn't supported. Probably need to track linebender/tiny-skia#1. Once that issue is taken care of however it could be a very good, more powerful alternative to andrew that'll allow for more complex decorations. Another issue would be system font selection depending on whether that's implemented as well.

@elinorbgr
Copy link
Member

Closing this PR as #183 made the underlying need outdated.

@elinorbgr elinorbgr closed this Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants