Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support resource deletion #21

Merged
merged 8 commits into from
Nov 20, 2024
Merged

Support resource deletion #21

merged 8 commits into from
Nov 20, 2024

Conversation

george-zubrienko
Copy link
Contributor

@george-zubrienko george-zubrienko commented Nov 16, 2024

Closes #18

Scope

  • Implement missing handler for DeleteFunc for MLA events - allows us to initiate cascade deletion of MLA and related resources in shards clusters

Copy link

New coverage report available ✨

Copy link

New coverage report available ✨

@george-zubrienko george-zubrienko marked this pull request as ready for review November 19, 2024 09:51
@george-zubrienko george-zubrienko requested a review from a team as a code owner November 19, 2024 09:51
Copy link

New coverage report available ✨

Copy link

New coverage report available ✨

Copy link

New coverage report available ✨

Copy link

New coverage report available ✨

Copy link

New coverage report available ✨

Copy link

New coverage report available ✨

Copy link

@adelinag08 adelinag08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I have a suggestions and a comment. I think it will be better if we extract the functionality for attempting reading metadata and recovering from handleObject into a separate method.

Copy link

New coverage report available ✨

Copy link

New coverage report available ✨

@george-zubrienko george-zubrienko merged commit 85ed348 into main Nov 20, 2024
1 check passed
@george-zubrienko george-zubrienko deleted the deletion-support branch November 20, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource deletion is not supported
2 participants