need to close sql.Rows #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edulop91
reviewed
Feb 13, 2019
| @@ -139,6 +139,7 @@ func readGrants(db *sql.DB, roleName string) ([]*grant, error) { | |||
| stmt := fmt.Sprintf(`SHOW GRANTS OF ROLE "%s"`, roleName) | |||
| log.Printf("[DEBUG] stmt %s", stmt) | |||
| rows, err := sdb.Queryx(stmt) | |||
| defer rows.Close() | |||
There was a problem hiding this comment.
Wonder if rows.Close() will panic when there's an error
edulop91
approved these changes
Feb 13, 2019
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
=========================================
+ Coverage 76.06% 76.1% +0.04%
=========================================
Files 15 15
Lines 564 565 +1
=========================================
+ Hits 429 430 +1
Misses 91 91
Partials 44 44 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.