Fix a small connection leak #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a connection leak which causes open connections to accumulate for each schema that gets refreshed. This probably doesn't manifest as a user-facing bug, but it certainly can't hurt to merge a fix. For an explanation on how I discovered and tested this, see the following github issue comment: Snowflake-Labs#69 (comment)
pwnage101
force-pushed
the
fix-connection-leak
branch
from
606608e to
9fa5798
Compare
ryanking
suggested changes
Sep 9, 2019
| @@ -264,11 +264,13 @@ func SchemaExists(data *schema.ResourceData, meta interface{}) (bool, error) { | |||
| return false, err | |||
| } | |||
|
|
|||
| exists := false | |||
There was a problem hiding this comment.
Seems like it would be simpler to just use defer rows.Close()?
There was a problem hiding this comment.
Okay, I'll update tomorrow.
There was a problem hiding this comment.
actually I did a pass to add this everywhere that I think is relevant- #74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a connection leak which causes open connections to accumulate
for each schema that gets refreshed. This probably doesn't manifest as
a user-facing bug, but it certainly can't hurt to merge a fix.
For an explanation on how I discovered and tested this, see the
following github issue comment:
#69 (comment)