Fix build error with CGAL 5.6 with -std=gnu++17 on Fedora #3045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Surface_mesh iterators no longer return references, so it's necessary to use const references or copies when iterating.
jbroadus
force-pushed
the
fix-cgal-error
branch
from
ce00f63 to
fd1ce38
Compare
SoftFever
reviewed
Dec 9, 2023
SoftFever
changed the title
SoftFever
approved these changes
Dec 9, 2023
andir
pushed a commit
to andir/OrcaSlicer
that referenced
this pull request
Aug 12, 2024
Surface_mesh iterators no longer return references, so it's necessary to use const references or copies when iterating. This was previously merged in SoftFever#3045 but isn't references in the current main branch anymore. Not where why it is gone but the issue still persists and thus the patch should still be added.
andir
pushed a commit
to andir/OrcaSlicer
that referenced
this pull request
Aug 12, 2024
Surface_mesh iterators no longer return references, so it's necessary to use const references or copies when iterating. This was previously merged in SoftFever#3045 but isn't references in the current main branch anymore. No idea where why it is gone but the issue still persists and thus the patch should still be added.
andir
pushed a commit
to andir/OrcaSlicer
that referenced
this pull request
Aug 12, 2024
Surface_mesh iterators no longer return references, so it's necessary to use const references or copies when iterating. This was previously merged in SoftFever#3045 but isn't references in the current main branch anymore. No idea where why it is gone but the issue still persists thus the patch should still be added.
andir
pushed a commit
to andir/OrcaSlicer
that referenced
this pull request
Aug 12, 2024
Surface_mesh iterators no longer return references, so it's necessary to use const references or copies when iterating. This was previously merged in SoftFever#3045 but isn't references in the current main branch anymore. No idea where why it is gone, but the issue still persists thus the patch should still be added.
andir
pushed a commit
to andir/OrcaSlicer
that referenced
this pull request
Aug 12, 2024
Surface_mesh iterators no longer return references, so it's necessary to use const references or copies when iterating. This was previously merged in SoftFever#3045 but isn't references in the current main branch anymore. No idea where why it is gone, but the issue still persists thus the patch should still be added.
SoftFever
pushed a commit
that referenced
this pull request
Aug 18, 2024
* Fix build with CGAL 5.6 Surface_mesh iterators no longer return references, so it's necessary to use const references or copies when iterating. This was previously merged in #3045 but isn't references in the current main branch anymore. No idea where why it is gone, but the issue still persists thus the patch should still be added.
henrivdr
pushed a commit
to henrivdr/OrcaSlicer
that referenced
this pull request
Aug 18, 2024
* Fix build with CGAL 5.6 Surface_mesh iterators no longer return references, so it's necessary to use const references or copies when iterating. This was previously merged in SoftFever#3045 but isn't references in the current main branch anymore. No idea where why it is gone, but the issue still persists thus the patch should still be added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surface_mesh iterators no longer return references, so it's necessary to use const references or copies when iterating.