Skip to content

Commit

Permalink
Fix build with CGAL 5.6 (again) (SoftFever#6439)
Browse files Browse the repository at this point in the history
* Fix build with CGAL 5.6

Surface_mesh iterators no longer return references, so it's necessary to
use const references or copies when iterating.

This was previously merged in SoftFever#3045 but isn't references in the
current main branch anymore. No idea where why it is gone, but the issue
still persists thus the patch should still be added.
  • Loading branch information
andir authored and henrivdr committed Aug 18, 2024
1 parent fd230e4 commit 70ff19b
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/libslic3r/MeshBoolean.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,6 @@ indexed_triangle_set cgal_to_indexed_triangle_set(const _Mesh &cgalmesh)
const auto &vertices = cgalmesh.vertices();
int vsize = int(vertices.size());

// HvdR: https://github.com/SoftFever/OrcaSlicer/pull/6439
for (const auto &vi : vertices) {
auto &v = cgalmesh.point(vi); // Don't ask...
its.vertices.emplace_back(to_vec3f(v));
Expand Down

0 comments on commit 70ff19b

Please sign in to comment.