Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat,将原有的“验证文本”改为“断言文本”,允许指定比较方式为等于,不等于,包含,不包含四种模式,满足更丰富的应用场景 #348

Merged
merged 5 commits into from
May 22, 2023

Conversation

caofengbin
Copy link
Contributor

@caofengbin caofengbin commented May 22, 2023

Whether this PR is eventually merged or not, Sonic will thank you very much for your contribution.

无论此PR最终是否合并,Sonic组织都非常感谢您的贡献。

Checklist

  • The title starts with fix, fea, or doc. | 标题为fix、feat或doc开头。
  • I have checked that there are no duplicate pull requests with this request. | 我已检查没有与此请求重复的拉取请求。
  • I have considered and confirmed that this submission is valuable to others. | 我已经考虑过,并确认这份呈件对其他人很有价值。
  • I accept that this submission may not be used. | 我接受此提交可能不会被使用。

Description

旧的getText,getWebViewText,getPocoText指令,比较文本只能支持相等的场景,如果想支持包含,不包含,不等于等场景,需要先取出文本到变量,然后再调用断言,比较麻烦。

本次pr对该指令做增强处理,UI效果如下:

image

运行效果如下:

image

旧的getText,getWebViewText,getPocoText指令在agent端依然保留,用户从老版本升级上来之后,老的用例依然可用,但是UI选择步骤的入口,不再提供“验证文本”的操作,统一改为使用“断言文本”

@prlabeler prlabeler bot added the feature label May 22, 2023
@caofengbin caofengbin changed the title feat,将原有的“验证文本”改为“断言文本”,运行指定比较方式为等于,不等于,包含,不包含四种模式,满足更丰富的应用场景 feat,将原有的“验证文本”改为“断言文本”,允许指定比较方式为等于,不等于,包含,不包含四种模式,满足更丰富的应用场景 May 22, 2023
Copy link
Member

@ZhouYixun ZhouYixun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

部分需要调整

@caofengbin
Copy link
Contributor Author

部分需要调整

已修改完成,辛苦review下

Copy link
Member

@ZhouYixun ZhouYixun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mg

@ZhouYixun ZhouYixun merged commit a6d7f10 into SonicCloudOrg:main May 22, 2023
@caofengbin caofengbin deleted the feature/complete_text_assert branch June 4, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants