Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat,将原有的“验证文本”改为“断言文本”，允许指定比较方式为等于，不等于，包含，不包含四种模式，满足更丰富的应用场景 #250

Merged
merged 5 commits into from
May 22, 2023
Merged

feat,将原有的“验证文本”改为“断言文本”，允许指定比较方式为等于，不等于，包含，不包含四种模式，满足更丰富的应用场景 #250

merged 5 commits into from
May 22, 2023

Conversation

caofengbin
Copy link
Contributor

@caofengbin caofengbin commented May 22, 2023 •
edited
Loading

Whether this PR is eventually merged or not, Sonic will thank you very much for your contribution.

无论此PR最终是否合并，Sonic组织都非常感谢您的贡献。

Checklist

  • The title starts with fix, fea, or doc. | 标题为fix、feat或doc开头。
  • I have checked that there are no duplicate pull requests with this request. | 我已检查没有与此请求重复的拉取请求。
  • I have considered and confirmed that this submission is valuable to others. | 我已经考虑过，并确认这份呈件对其他人很有价值。
  • I accept that this submission may not be used. | 我接受此提交可能不会被使用。

Description

Agent端已提交的pr，同步的web端UI变更

@prlabeler prlabeler bot added the feature label May 22, 2023
ZhouYixun
ZhouYixun reviewed May 22, 2023
View reviewed changes
src/components/StepUpdate.vue Outdated
@@ -1027,6 +1035,10 @@ const iOSOptions = ref([
value: 'getPocoText',
label: '验证文本',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个验证文本应该去掉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯，这里梳理的时候漏掉这个了

ZhouYixun
ZhouYixun requested changes May 22, 2023
View reviewed changes
Copy link
Member

@ZhouYixun ZhouYixun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还有部分需要调整

@caofengbin
Copy link
Contributor Author

还有部分需要调整

已经修改完成，辛苦review下。

ZhouYixun
ZhouYixun approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@ZhouYixun ZhouYixun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

暂时看没问题了，你可以多跑测试一下，可以检查下content和text字段对应的对不对，主要怕影响了旧数据

@ZhouYixun ZhouYixun merged commit c3fb0ed into SonicCloudOrg:main May 22, 2023
@caofengbin caofengbin deleted the feature/complete_text_assert branch June 4, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhouYixun ZhouYixun ZhouYixun approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caofengbin @ZhouYixun