Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JMT update proofs #717

Closed
wants to merge 11 commits into from
Closed

Conversation

preston-evans98
Copy link
Member

Description

Update zk_storage to use jmt::update proofs. This fixes the soundness bug in our proofs and may improve performance.

Linked Issues

Testing

This PR should be exercised by the demo-prover tests. We should wait to merge it until #715 is complete. We should also add integration tests exercising the whole "prover" workflow outside of Risc0.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #717 (201267d) into nightly (cf6fd44) will increase coverage by 0.5%.
Report is 1 commits behind head on nightly.
The diff coverage is 100.0%.

Files Changed Coverage Δ
module-system/sov-state/src/lib.rs 78.2% <ø> (ø)
module-system/sov-state/src/witness.rs 66.6% <ø> (+13.1%) ⬆️
module-system/sov-state/src/prover_storage.rs 96.6% <100.0%> (-0.1%) ⬇️
module-system/sov-state/src/zk_storage.rs 57.6% <100.0%> (+0.5%) ⬆️

... and 2 files with indirect coverage changes

@preston-evans98
Copy link
Member Author

Implemented by #908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update jmt to remove honest treereader assumption.
1 participant