Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jmt update proofs. Add Storage::Root generic. #908

Merged
merged 14 commits into from
Sep 22, 2023

Conversation

preston-evans98
Copy link
Member

Description

This PR switches from our temporary (insecure) method of proving updates to the new jmt update proofs that @theochap implemented while he was here. In order to make this change, it was convenient to clean up many of the hard-coded [u8;32]s scattered throughout the codebase and replace them with a generic Storage::Root type.

Linked Issues

Testing

This change is covered by existing tests.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #908 (6c9769a) into nightly (2c51dd9) will increase coverage by 0.1%.
The diff coverage is 78.9%.

❗ Current head 6c9769a differs from pull request most recent head 683f8e0. Consider uploading reports for the commit 683f8e0 to get more accurate results

Files Changed Coverage Δ
adapters/risc0/src/guest.rs 63.4% <0.0%> (-1.1%) ⬇️
adapters/risc0/src/host.rs 16.4% <0.0%> (-0.5%) ⬇️
module-system/sov-state/src/lib.rs 84.2% <ø> (ø)
module-system/sov-state/src/witness.rs 66.6% <ø> (+13.1%) ⬆️
rollup-interface/src/state_machine/optimistic.rs 0.0% <ø> (ø)
rollup-interface/src/state_machine/stf.rs 85.7% <ø> (ø)
rollup-interface/src/state_machine/zk/mod.rs 100.0% <ø> (ø)
...mplementations/sov-attester-incentives/src/call.rs 87.0% <48.8%> (-3.1%) ⬇️
full-node/db/sov-db/src/ledger_db/mod.rs 90.8% <77.7%> (-0.7%) ⬇️
full-node/sov-stf-runner/src/runner.rs 79.1% <77.7%> (ø)
... and 12 more

... and 9 files with indirect coverage changes

@preston-evans98 preston-evans98 added this pull request to the merge queue Sep 22, 2023
Merged via the queue into nightly with commit 735ddd5 Sep 22, 2023
@preston-evans98 preston-evans98 deleted the preston/update-proofs branch September 22, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update jmt to remove honest treereader assumption.
2 participants