Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate M-CHAT R/F questionnaire into an updated Schedule view #35

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Oct 26, 2023

Integrate M-CHAT R/F questionnaire into an updated Schedule view

♻️ Current situation & Problem

The current ScheduleView implementation is directly taken from the SpeziTemplateApplication. In our application, we won't need to schedule repeated Tasks or questionnaires, but instead have a fixed set of questionnaires to be completed for each patient.

💡 Proposed solution

This PR adds initial support for the M-CHAT R/F questionnaire and restructures the ScheduleView to show a fixed set of tasks depending on the completion status of a given patient.

⚙️ Release Notes

  • A new ScheduleView shows all Task to be completed for a selected patient.
  • Added initial support for the M-CHAT R/F questionnaire.

➕ Additional Information

Related PRs

--

Testing

New UI Tests were added to cover the added UI components.

Reviewer Nudging

--

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg changed the title New Schedule view, integrating M-CHAT R/F questionnaire Integrate M-CHAT R/F questionnaire into an updated Schedule view Oct 26, 2023
@Supereg Supereg marked this pull request as ready for review October 26, 2023 22:40
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #35 (9264294) into main (67e9271) will increase coverage by 1.62%.
The diff coverage is 85.30%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   83.35%   84.96%   +1.62%     
==========================================
  Files          62       63       +1     
  Lines        2269     2306      +37     
==========================================
+ Hits         1891     1959      +68     
+ Misses        378      347      -31     
Files Coverage Δ
NAMS/Home.swift 93.75% <100.00%> (ø)
NAMS/NAMSAppDelegate.swift 97.06% <ø> (-0.08%) ⬇️
NAMS/NAMSStandard.swift 100.00% <100.00%> (+83.34%) ⬆️
NAMS/Onboarding/OnboardingFlow.swift 100.00% <100.00%> (ø)
NAMS/Patients/CurrentPatientLabel.swift 100.00% <100.00%> (ø)
.../Patients/Questionnaire/PatientQuestionnaire.swift 100.00% <100.00%> (ø)
NAMS/Tiles/QuestionnaireTile.swift 100.00% <100.00%> (ø)
NAMS/Tiles/TileType.swift 100.00% <100.00%> (ø)
NAMS/Utils/Helper/Binding+Negate.swift 100.00% <ø> (ø)
NAMS/Utils/Helper/Bundle+Image.swift 0.00% <ø> (ø)
... and 11 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67e9271...9264294. Read the comment docs.

@Supereg Supereg merged commit 105f8bd into main Oct 26, 2023
@Supereg Supereg deleted the feature/m-chat-rf branch October 26, 2023 22:46
Supereg added a commit that referenced this pull request Oct 27, 2023
# Fix release builds

## ♻️ Current situation & Problem
With the latest changes of adding a new ScheduleView and the M-CHAT R/F
questionnaires (see #35), we broke the release build action.
## 💡 Proposed solution
This PR fixes the compilation issues and adds a PR Action step to verify
release build before merging a PR.
## ⚙️ Release Notes 
* Fix release builds
## ➕ Additional Information

### Related PRs
--

### Testing
GitHub Action was added to build the release scheme for every PR.

### Reviewer Nudging
--

### Code of Conduct & Contributing Guidelines 

By submitting creating this pull request, you agree to follow our [Code
of
Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md):
- [x] I agree to follow the [Code of
Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md).
@Supereg Supereg mentioned this pull request Oct 28, 2023
1 task
Supereg added a commit that referenced this pull request Oct 28, 2023
# Implement EEG Recordings as a Task

## ♻️ Current situation & Problem
With #35 we introduced an updated ScheduleView that provides an overview
for all the due tasks for a selected patient. This builds upon this
infrastructure and renders the EEG Recording view as a Task tile.

## ⚙️ Release Notes 
* Visualize EEG Recording as a task in the Schedule view.

## ➕ Additional Information

### Related PRs
- #35 

### Testing
_TBA_

### Code of Conduct & Contributing Guidelines 

By submitting creating this pull request, you agree to follow our [Code
of
Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md):
- [x] I agree to follow the [Code of
Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant