Adding and removing Actors from the Combat Tracker can misalign the Disposition Labelling #1340
Comments
wrycu
added a commit
that referenced
this issue
Feb 21, 2024
* handle CSS issues with the "active" class not being properly set * handle confusion around which actor is active * localize strings for hidden slots * remove slot names for hidden slots (only applies for non-GMs) * correct image "has gone" state not being reset at the start of a new round * handle removing combatants confusing the claimed slot state #1343 #1340
|
Mostly, maybe even entirely, fixed. Thanks for the report; will be released in |
|
My latest changes for visibility re-broke this. Will need to fix it again. |
wrycu
added a commit
that referenced
this issue
Mar 15, 2024
* now properly handles removing combatants by swapping claims of slots to the ID of the slot, rather than the index of it #1340
|
Done again. But better! |
Esrin
pushed a commit
that referenced
this issue
Mar 21, 2024
* fix(combat): correct claimed slot bug * now properly handles removing combatants by swapping claims of slots to the ID of the slot, rather than the index of it #1340 * feat(combat): minor bugfixes * removed "toggle visibility" button, since it's not yet implemented * corrected "remove combatant" not properly determining if a slot was claimed * corrected existing claim detection for non-GMs passing their turn #1374 * fix(combat): tracker fix * fixes bug for unclaimed slots breaking the tracker prior to beginning combat #1374
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Experimenting with the Combat tracker I've discovered that you can misalign disposition when removing dead actors (NPCs being the most common).
The text was updated successfully, but these errors were encountered: