Check for token visibility in new combat tracker

[wrycu]

Don't show hidden actors

[wrycu]

On further thought, I don't think this is valid. You should be made aware that actors are taking initiative slots, even if you don't know what they're doing. Let's see if anyone feels strongly about this.

[Myrathi]

I can see why you would and wouldn't want this and I think both reasons are entirely valid? A GM would likely still want to hide unknown actors from players that haven't seen/encountered them, yet, but seeing/validating when slots are used is still important.

Option 1: Perhaps, instead of just hiding them entirely from view, have the GM able to view the token normally (with a little "hidden" eye over them, like the on the map?) but, to players, it's just an unknown/unnamed token with a big "?" question mark in the middle of it? Doesn't matter if the players can only see 4 '?' identical icons, at that point, so long as the GM knows.

Option 2: the GM can see the available tokens normally, the players don't see anything at all, and when the GM adds the hidden token to a slot, the players just see "Used" or "Unknown" with no interaction options.

Either way, you could have a system config/option to allow players to see hidden enemies in the list and another to see hidden enemies that take up slots, letting the GM decide how transparent they want encounters to be.

[wrycu]

Since you commented without any prompting by anyone, I'll post this on Discord and see if anyone else feels strongly one way or another.

I'm fine implementing it, I just want to see how many people feel strongly to see if it needs to be included in this release or not.

[Torticute]

Seeing how claiming slots shows the actor taking it, I would prefer it if there was a way to hide the actual actor while still letting players know that there is something going on beyond what they see, if that makes sense, basically option 2 from the comment above the previous one.

[Ebakthecat]

I also agree with slots being there, but not sure what it could be. I even think the slots could be neutral as it could represent allies or enemies, the players just do not know. Could be a good way for a GM to build tension.

My only concern is the players then metagaming or afraid to do something because they feel it would come off as metagaming.

[DraculNoctem]

I think the slots for hidden tokens should be marked as unknown to players. As was mentioned in another comment, I think it would be nice if those slots were marked as neutral to keep a form of mystery for the players.

[Myrathi]

I'll post this on Discord and see if anyone else feels strongly one way or another.

I'm fine implementing it, I just want to see how many people feel strongly to see if it needs to be included in this release or not.

I'll use this regardless, so it's appreciated either way. (:

Since you commented without any prompting by anyone

I track issues via email, so I saw your last comment go past and clicked through. :D

[wrycu]

Pushed an initial commit (see above). Remaining action items:

• Actor summary at the top currently exposes actor image after a hidden token acts
• The combat tracker does not update when tokens are hidden/unhidden (need to find and hook that function)
• Need to localize some strings
• Need to further investigate ramifications of my approach (pulling data from this.viewed instead of the super.getData call)
• Need further testing

[wrycu]

• localize strings
• hidden token retains "active" class for non-GM after passing turn
• images in summary do not reset to "has not gone" after a new round (I think this is from the swap to this.turns instead of data.turns)
• making a hidden token visible confuses the active class for non-GM

[wrycu]

• claiming a slot with a visible token after a hidden token claims a slot reveals the image in the actor summary for non-GMs

[wrycu]

I think I ironed out all the bugs here. Filed a PR; will be released in 1.807.

[wrycu]

@Myrathi I didn't mean to imply your opinion is unwelcome, by the way. I just meant that I hadn't sent the issue to Discord and asked for people's opinions.

[Myrathi]

Definitely read it the way you intended it. No worries here. 👍