Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xp): Include species modifiers when calculating characteristic cost #1646

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

obrenckle
Copy link
Contributor

@obrenckle obrenckle commented Aug 5, 2024

This PR adds the specie characteristic modifier when calculating upgrade cost.

The dialog window shows the new characteristic without non-species (cybernetic, etc) modifiers.

Fixes #1638

@obrenckle obrenckle force-pushed the fix_characteristic_cost branch 2 times, most recently from eb81c3a to fa2a59a Compare August 5, 2024 21:00
@obrenckle obrenckle force-pushed the fix_characteristic_cost branch from fa2a59a to cfdf66c Compare August 7, 2024 07:53
@obrenckle obrenckle changed the title fix(xp) Include specie modifiers when calculating characteristic cost fix(xp): Include specie modifiers when calculating characteristic cost Aug 7, 2024
@obrenckle obrenckle changed the title fix(xp): Include specie modifiers when calculating characteristic cost fix(xp): Include species modifiers when calculating characteristic cost Aug 7, 2024
@wrycu wrycu merged commit b339073 into StarWarsFoundryVTT:main Aug 7, 2024
@wrycu
Copy link
Collaborator

wrycu commented Aug 7, 2024

Thanks for the help!

@obrenckle obrenckle deleted the fix_characteristic_cost branch August 8, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Characteristics are not adding correctly
2 participants