Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSM #708

Merged
merged 110 commits into from
Aug 25, 2023
Merged

LSM #708

merged 110 commits into from
Aug 25, 2023

Conversation

sampocs
Copy link
Collaborator

@sampocs sampocs commented Apr 6, 2023 •
edited
Loading

Tech Spec

https://docs.google.com/document/d/1wqMrXltiZUUQC4vZp6FmZNeD3IXYLrliZZjby5nrJaQ/edit#

TODO

Phase 1

  • Scaffold @sampocs
  • Update protos @sampocs
  • Implement core Keeper Functions @ethan-stride
  • Implement helper keeper functions @ethan-stride
  • Implement the LSMDeposits queries @ethan-stride
  • Implement LSMLiquidStake message type ValidateBasic @ethan-stride
  • Implement MsgLSMLiquidStake @sampocs
  • Implement RefundLSMToken @sampocs
  • Implement LSMTokenTransferCallback @sampocs
  • Update interchain queries module @sampocs
  • Rename host zone accounts @sampocs
  • Implement DetokenizeLSMDeposit and DetokenizeSharesCallback @sampocs
  • Implement EndBlocker and modify RestoreInterchainAccount @sampocs
  • Implement RebalanceTokenizedDeposits and RebalanceTokenizedDepositsCallback @sampocs
  • Update redemption rate calculation @sampocs

Phase 2

  • Remove unbalanced delegation field @sampocs
  • Remove AddLSMTokenDeposit and enforce 1 record per denom @ethan-stride
  • Modify rebalancing to batch messages @ethan-stride
  • Modify ValidatorExchangeRateCallback and DelegatorSharesCallback
  • Modify unbonding flow @sampocs

Phase 3

  • Testing
    • Add integration tests
    • Add CLI unit tests
  • Finalize
    • Cleanup TODOs
    • Add events
    • Update init/export genesis

Dockernet cleanup before merge

  • Revert config.sh
  • Revert run_all_test.sh
  • Revert sdk message types
  • Revert dockernet relayer
  • Remove LSM host

@github-actions github-actions bot removed C:mint dependencies Pull requests that update a dependency file C:epochs labels Aug 15, 2023
@sampocs sampocs changed the title [DRAFT] LSM LSM Aug 25, 2023
ethan-stride
ethan-stride approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@ethan-stride ethan-stride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few lint issues we can fix in the future but otherwise I think we are ready to merge!

@sampocs sampocs marked this pull request as ready for review August 25, 2023 18:11
@sampocs sampocs merged commit 533bb92 into main Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethan-stride ethan-stride ethan-stride approved these changes

Assignees
No one assigned
Labels
C:app-wiring C:CLI C:docs C:interchainquery C:proto C:records C:stakeibc C:submodules T:build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sampocs @ethan-stride