Bump simplecov to v0.22.0 #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrom
reviewed
Jan 13, 2025
| @@ -18,5 +18,4 @@ gem 'rubocop', '~> 1.68' | |||
| gem 'rubocop-rake', '~> 0.6' | |||
| gem 'rubocop-rspec', '~> 3.2' | |||
| gem 'sinatra', '~> 4.1' | |||
| # Limit simplecov to 0.17.x due to https://github.com/codeclimate/test-reporter/issues/413 | |||
| gem 'simplecov', '~> 0.17', '< 0.18' | |||
| gem 'simplecov', '~> 0.22.0' | |||
There was a problem hiding this comment.
Ooft.. i'd given up on that being fixed. Thanks for the PR! Although per the issue thread it looks like this change would also require the test reporter ID ENV being moved from the "publish" step, to apply to the rspec step(s) too. Likely better to just move it into the global env scope..
|
thanks @murajun1978 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump simplecov to latest version because the issue of Code Climate fixed with v0.20.0.
changelog: https://github.com/simplecov-ruby/simplecov/blob/main/CHANGELOG.md#0200-2020-11-29
issue: codeclimate/test-reporter#413