Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump simplecov to v0.22.0 #276

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Bump simplecov to v0.22.0 #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd2b33f
Bump simplecov to v0.22.0
murajun1978 Dec 30, 2024
8efe812
Define CC reporter ID at the global level (simplecov 0.20+ requires it)
abrom Jan 13, 2025
e08e5c7
Fix rubocop lint
abrom Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ on:
pull_request:
branches: [main]

env:
CC_TEST_REPORTER_ID: 5cfed40102c670b5c9e509730782b751939ddbe53fc57c317b718f635bab1ce8

jobs:
test:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -81,5 +84,3 @@ jobs:

- name: Test & publish code coverage
uses: paambaati/[email protected]
env:
CC_TEST_REPORTER_ID: 5cfed40102c670b5c9e509730782b751939ddbe53fc57c317b718f635bab1ce8
3 changes: 1 addition & 2 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,5 @@ gem 'rspec', '~> 3.13'
gem 'rubocop', '~> 1.68'
gem 'rubocop-rake', '~> 0.6'
gem 'rubocop-rspec', '~> 3.2'
gem 'simplecov', '~> 0.22.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooft.. i'd given up on that being fixed. Thanks for the PR! Although per the issue thread it looks like this change would also require the test reporter ID ENV being moved from the "publish" step, to apply to the rspec step(s) too. Likely better to just move it into the global env scope..

gem 'sinatra', '~> 4.1'
# Limit simplecov to 0.17.x due to https://github.com/codeclimate/test-reporter/issues/413
gem 'simplecov', '~> 0.17', '< 0.18'
Loading