border color issues caused by $color generated properties that conflict in some rules.

[the-j0k3r]

• Browser:
• Operating System:
• Link to page with the issue: https://github.com/settings/admin change nick or any issue and cloick lock conversation.
• Screenshot:

GitHub-Dark/src/gen/mappings.js

Line 33 in 050753c

"$color: #444d56": "#afafaf", // .full-commit .commit-desc pre

is the guilty rule

its generating a bright border for .Box--overlay this bright VALUE is OK for some other rules but NOT this ones border.

  /* github-mobile: "#fff", "#444d56", "rgba(0,0,0,.4)" */
  body[class="page-responsive"] .Box--overlay {
    background-color: #151515;
    border-color: #afafaf;
    box-shadow: 0 0 18px #000;
  }

@silverwind Im out of ideas, $color is more trouble than its worth IMO. Unless its A LOT smarter

[the-j0k3r]

and so on goes this song

[the-j0k3r]

This also affects border for https://github.com/bus-stop/terminus/pull/104/checks?check_run_id=885718952 for .CheckRun-header

[silverwind]

There ought to be issues like that but generally I like to strive for a inversion or close to it, but it'll not work on all cases and we should just override those specific issues.