Warning toasts need a better icon color

[xt0rted]

I don't know if the warning version of the toast notifications is used anywhere on the site yet, but OctoLinker is building on them and it'll be in the next release (should be in a day or two).

I just learned that these were a thing on github as I've never seen them used before. They're on the notification page when grouping by repo and using the bulk mark as done option.

Here's what the different variations look like:

Class	Preview
.Toast--loading
.Toast--success
.Toast--error
.Toast--info
.Toast--warning

[the-j0k3r]

Whatever color is decided for this, keep in mind that it shouldn't interfere with regular GitHub stuff else it will break other parts.

I wanted to remove extensions because even with prefixes if you alter a color meant for them if that color is also used by us it will change that too.

On another matter, I have an addon style in the works that allows you to pick colors within a reasonable scope

see #1113 (comment) for an older POC

Also it can change the text color to black when the background color is light among other things.

However It wont be compatible with extensions, I dont use them and just dont have the interest in supporting extensions.

Just please dont break GHD more than it already is.

[xt0rted]

The toasts are part of GitHub, they're used on the new notification page (see the gif in the linked PR for a demo of them). We're going to be using them so we don't have to add a custom ui element into the extension.

I'm going to look into this more once OctoLinker/OctoLinker#975 is merged. I'm guessing this will probably be a manual style instead of a generator mapping.

[the-j0k3r]

I'm going to look into this more once OctoLinker/OctoLinker#975 is merged. I'm guessing this will probably be a manual style instead of a generator mapping.

Yea, in this case please consider avoiding using !important where possible its a PITA in most out manual overrides.

Once its merged and live would be nice to add to the addon style im working on atm.

[silverwind]

I just changed to foreground to near-black:

I think this is a better approach than going for brown shades, at least in this case.