added an aspect ratio to the manga card. #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriaMoradi
requested changes
Oct 30, 2021
src/components/MangaCard.tsx
Outdated
| display: 'flex', | ||
| aspectRatio: '9/14', |
There was a problem hiding this comment.
how about the respected 225/350? I know it's the same ratio but it's the golden number when making manga...
also add a comment for future generations reading the code.
AriaMoradi
requested changes
Oct 31, 2021
Comment on lines
+21
to
+23
| // Preserve the shape of the manga cards, without this the manga card would chage it's | ||
| // if all the images in a row failed to load then the whole row would change into a | ||
| // square shape |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an aspect ratio to the MangaCard which prevents resizing of the component. Before this if an image failed to load the component would go in a Square shape if it alone in the row, If all the images in a row failed to load then the whole row would change it's height,