Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added an aspect ratio to the manga card. #56

Merged
merged 2 commits into from
Oct 31, 2021
Merged

added an aspect ratio to the manga card. #56

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a5d31e
added an aspect ratio to the manga card.
ff2400t Oct 30, 2021
f13ac05
added a comment and chaged the ratio to the recommeded
ff2400t Oct 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/components/MangaCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,11 @@ import SpinnerImage from 'components/util/SpinnerImage';

const useStyles = makeStyles((theme) => ({
root: {
height: '100%',
width: '100%',
display: 'flex',
// Preserve the shape of the manga cards, without this the manga card would chage it's
// if all the images in a row failed to load then the whole row would change into a
// square shape
Comment on lines +21 to +23
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't make sense

aspectRatio: '225/350',
},
wrapper: {
position: 'relative',
Expand Down