Scoreboard: Fixed Icons sometimes missing

[TimGoll]

This PR fixes the scoreboard being stuck open after an icon is missing. This PR does this in two levels

• adding a safety check to make sure the scoreboard never stays stuck
• fixing the root cause that causes the breakage in the first place

The problem

Some entities register custom projectiles (like the boomerang) that are then registered as the inflictor. This breaks our current UI as I expected that the weapon is always a real TTT weapon. The change in this PR searches for an entity with the given name class, if no weapon was found.

I'm pretty sure that it fixes the two linked issues.

[EntranceJew]

minor overcorrection

[TimGoll]

The latent commit based on a suggestion by @ZenBre4ker should solve this. Are you sure you are on that commit?

[EntranceJew]

what's on the branch is on the branch

[TimGoll]

I have to test this tomorrow again, but looking at the code I don't see how this could happen

[ZenBre4ker]

Shouldnt there be 5 commits?

[EntranceJew]

for some reason the pull i performed an hour ago to be made aware of the branch did not include a commit performed over 3 hours ago

it isn't getting stuck but the boomerang isn't displaying anymore either

[TimGoll]

Oh well, I should test stuff after merging suggestions. No idea why it is broken, but I will take a look. Thanks for testing!

[TimGoll]

okay, I fixed and tested it. It works now in both cases.

The problem here was that util.WeaponForClass(data.wep) already does what I want and finds the correct projectile entity, therefore my check failed. The solution therefore is to check if a cached material exists.

Maybe it would be an idea to add material caching to entities as well in the future, I'm not so sure though. Nevertheless, this is a discussion for the future, this fallback for non-cached icons is useful, even if we decide to add caching to entities as this is a good way to prevent issues for edge cases

[EntranceJew]

tested, couldn't find a situation that broke the scoreboard or any equipment that didn't have an attribution, LGTM