refactor(query-core): improve type safety and performance in `getMuta…

…tionDefaults` (#8669) - Change return type to exclude mutationKey using OmitKeyof - Replace spread operator with Object.assign for better performance Co-authored-by: Dominik Dorfmeister <[email protected]>
TanStack · Mar 3, 2025 · 4d8c27b · 4d8c27b
1 parent c0f27f6
commit 4d8c27b
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/packages/query-core/src/queryClient.ts b/packages/query-core/src/queryClient.ts
@@ -605,14 +605,17 @@ export class QueryClient {
 
   getMutationDefaults(
     mutationKey: MutationKey,
-  ): MutationObserverOptions<any, any, any, any> {
+  ): OmitKeyof<MutationObserverOptions<any, any, any, any>, 'mutationKey'> {
     const defaults = [...this.#mutationDefaults.values()]
 
-    let result: MutationObserverOptions<any, any, any, any> = {}
+    const result: OmitKeyof<
+      MutationObserverOptions<any, any, any, any>,
+      'mutationKey'
+    > = {}
 
     defaults.forEach((queryDefault) => {
       if (partialMatchKey(mutationKey, queryDefault.mutationKey)) {
-        result = { ...result, ...queryDefault.defaultOptions }
+        Object.assign(result, queryDefault.defaultOptions)
       }
     })