Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(query-core): improve type safety and performance in getMutationDefaults #8669

Merged
merged 2 commits into from
Mar 3, 2025
Merged

refactor(query-core): improve type safety and performance in getMutationDefaults #8669

merged 2 commits into from
Mar 3, 2025

Conversation

samuel871211
Copy link
Contributor

@samuel871211 samuel871211 commented Feb 19, 2025 •
edited
Loading

Description

Improve type safety and performance in getMutationDefaults by:

  1. Using explicit return type OmitKeyof<MutationObserverOptions<any, any, any, any>, 'mutationKey'> to ensure the return type matches the type defined in setMutationDefaults
  2. Aligning implementation with getQueryDefaults by using Object.assign

@samuel871211
refactor(query-core): improve type safety and performance in `getMuta…
c821ecf 
…tionDefaults`

- Change return type to exclude mutationKey using OmitKeyof
- Replace spread operator with Object.assign for better performance
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 28, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit af7aa1e.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 4m 8s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 59s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-28 19:33:50 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 28, 2025

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8669

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8669

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8669

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8669

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8669

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8669

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8669

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8669

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8669

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8669

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8669

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8669

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8669

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8669

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8669

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8669

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8669

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8669

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8669

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8669

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8669

commit: af7aa1e

@codecov Codecov
Copy link

codecov bot commented Feb 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.11%. Comparing base (2bf7ec6) to head (af7aa1e).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8669       +/-   ##
===========================================
+ Coverage   46.31%   63.11%   +16.79%     
===========================================
  Files         199      135       -64     
  Lines        7552     4855     -2697     
  Branches     1731     1368      -363     
===========================================
- Hits         3498     3064      -434     
+ Misses       3674     1546     -2128     
+ Partials      380      245      -135
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 88.65% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 94.07% <100.00%> (ø)
@tanstack/query-devtools 4.78% <ø> (ø)
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/react-query 95.09% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.20% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 87.33% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.01% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@TkDodo TkDodo merged commit 4d8c27b into TanStack:main Mar 3, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo left review comments

@Nick-Lucas Nick-Lucas Nick-Lucas left review comments

Assignees
No one assigned
Labels
package: query-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samuel871211 @TkDodo @Nick-Lucas