Rewrite facade rendering #945
Open
+149
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could be improved quite a bit if there was a map of chunks that had facades; but adding that right now seems potentially out of scope. |
|
I've added a chunk map, fixing the above issue. It will check if the chunk has any facades, skipping the expensive lookup step. |
ferriarnus
requested changes
Dec 31, 2024
There was a problem hiding this comment.
I think most of this is good, just some small nitpicks. I do however think an alternative path to not render anything (or a replacement transparent overlay) when shaders are active is needed. This should be linked to a config as wel IMO (I don't mind doing this myself if you haven't worked with the neo config system yet). Thanks for the PR!
...nduits/src/main/java/com/enderio/conduits/common/conduit/block/ConduitBundleBlockEntity.java
Outdated
Show resolved
Hide resolved
...nduits/src/main/java/com/enderio/conduits/common/conduit/block/ConduitBundleBlockEntity.java
Show resolved
Hide resolved
enderio-conduits/src/main/java/com/enderio/conduits/mixin/BlockRenderDispatcherMixin.java
Show resolved
Hide resolved
enderio-conduits/src/main/java/com/enderio/conduits/client/ConduitFacadeRendering.java
Outdated
Show resolved
Hide resolved
embeddedt
reviewed
Dec 31, 2024
enderio-conduits/src/main/java/com/enderio/conduits/client/ConduitFacadeRendering.java
Outdated
Show resolved
Hide resolved
enderio-conduits/src/main/java/com/enderio/conduits/client/model/ConduitBlockModel.java
Outdated
Show resolved
Hide resolved
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This rewrites facade rendering to always use the additional chunk buffering system. Additionally, bugs have been fixed with shaders and mods, and the block breaking overlay now correctly shows when breaking a facade.
Checklist