Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darling::util::Override::as_mut should return Override<&mut T> #66

Closed
TedDriggs opened this issue Mar 19, 2019 · 0 comments
Closed

darling::util::Override::as_mut should return Override<&mut T> #66

TedDriggs opened this issue Mar 19, 2019 · 0 comments
Assignees
@TedDriggs
Labels
bug
Milestone
0.9.0

Comments

@TedDriggs
Copy link
Owner

Right now it accidentally returns Override<&T>, which isn't helpful.
@TedDriggs TedDriggs added the bug label Mar 19, 2019
@TedDriggs TedDriggs added this to the 0.9.0 milestone Mar 19, 2019
@TedDriggs TedDriggs self-assigned this Mar 19, 2019
TedDriggs added a commit that referenced this issue Mar 19, 2019
@TedDriggs
Make util::Override::as_mut return &mut T
910e779 
Fixes #66
@TedDriggs TedDriggs mentioned this issue Mar 19, 2019
Closed
TedDriggs added a commit that referenced this issue Mar 20, 2019
@TedDriggs
Make util::Override::as_mut return &mut T
4e46371 
Fixes #66
@TedDriggs TedDriggs mentioned this issue Mar 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TedDriggs TedDriggs

Labels
bug
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
1 participant
@TedDriggs