V0.9 staging #67
Closed
V0.9 staging #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make internal refactoring easier going forward. This change also removes dead code exposed by making the crates private. Fixes #58
* Replace trim_left_matches with trim_start_matches * Replace trim_right_matches with trim_end_matches
* Remove unnecessary lifetimes * Allow len without is_empty, as Error can never be empty Relates to #46
|
I'm wondering if I should defer enabling |
|
Dropping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for v0.9
darling_core::{codegen, options}private: Make darling_core::options and darling_core::codegen crate-private #58Override::as_mut: darling::util::Override::as_mut should return Override<&mut T> #66