Fix/badge/fixRibbonSkyline #3136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix ribbon abnormality under skyline. Problem due to clip-path not supported by skyline. Fallback to previouse implementation under skyline. fix Tencent#3130
jby0107
requested review from
anlyyao,
jarmywang,
jin0209 and
betavs
as code owners
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
fix #3130
💡 需求背景和解决方案
#3074 中ribbon实现改为使用clip-path，由于skyline不支持clip-path导致样式异常。此PR将skyline下ribbon实现改为了之前拼接的方法。由于实现方式相比最初的实现有一定变化，对demo中在t-cell上使用ribbon的示例在skyline下的offset值做了调整。
📝 更新日志
fix(badge): 修复badge的ribbon样式在skyline下异常问题
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单