-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Badge): use pseudo-element instead #3144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -295 B (0%) Total Size: 210 kB
ℹ️ View Unchanged
|
tips:原方案只处理了顶部溢出,底部溢出未考虑。综合来看 还是建议角标使用伪元素实现,角标溢出问题从父容器/cell组件处理 |
Size Change: -295 B (0%) Total Size: 210 kB
ℹ️ View Unchanged
|
jarmywang
approved these changes
Sep 14, 2024
Size Change: -263 B (0%) Total Size: 210 kB
ℹ️ View Unchanged
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是?
🔗 相关 Issue
fix #3130
Duplicate of #3136
💡 需求背景和解决方案
📝 更新日志
fix(Badge):
ribbon
类型徽标改用伪元素实现本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单